Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mocks package #61

Open
alexshtin opened this issue Mar 13, 2020 · 1 comment
Open

Remove mocks package #61

alexshtin opened this issue Mar 13, 2020 · 1 comment

Comments

@alexshtin
Copy link
Member

alexshtin commented Mar 13, 2020 •
edited by sync-by-unito bot
Loading

mocks package uses mockery and we are using gomocks everywhere else. Mocks can be easily generated by customers using mockgen tool from gomocks framework.
@alexshtin alexshtin mentioned this issue Mar 13, 2020
Merged
@alexshtin
Copy link
Member Author

Apparently this is not as easy as it looks. Good issues to start with:
cadence-workflow/cadence-go-client#929
cadence-workflow/cadence-go-client#928

@alexshtin alexshtin mentioned this issue Apr 7, 2020
Open
@dnr dnr mentioned this issue Jun 28, 2022
Merged
@ash2k ash2k mentioned this issue Nov 21, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@josh-berry @alexshtin @Quinn-With-Two-Ns