Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding encryption example using a KMS and JWT-based auth #138

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

phillipskevin
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
All committers have signed the CLA.

encryption_jwt/README.md Show resolved Hide resolved
encryption_jwt/README.md Outdated Show resolved Hide resolved
encryption_jwt/README.md Show resolved Hide resolved
encryption_jwt/encryptor.py Outdated Show resolved Hide resolved
encryption_jwt/codec_server.py Outdated Show resolved Hide resolved
encryption_jwt/codec_server.py Outdated Show resolved Hide resolved
encryption_jwt/codec_server.py Outdated Show resolved Hide resolved
@cretz
Copy link
Member

cretz commented Aug 28, 2024

Thanks! Added some review comments. Also may want to poe format and poe lint-types. Also may need to sign the CLI. Feel free to add a test or two, but not required.

@phillipskevin
Copy link
Author

Thanks @cretz for all of the great feedback. I'll make these updates in the next day or two and will let you know!

@phillipskevin
Copy link
Author

Thanks for all the suggestions, @cretz. I think I've addressed everything. Let me know if you have any more feedback.

encryption_jwt/encryptor.py Outdated Show resolved Hide resolved
@cretz
Copy link
Member

cretz commented Oct 1, 2024

Make need to run poe lint to confirm type checking.

@phillipskevin
Copy link
Author

Should be good to go now, @cretz. Thanks again!

@cretz
Copy link
Member

cretz commented Oct 2, 2024

@phillipskevin - Looks like there's a type error. Specifically, since we allow our Python samples to run in in all non-EOL Python versions, you have to change things like tuple[bytes, bytes] to typing.Tuple[bytes, bytes] for 3.8 to work.

For this error:

Library stubs not installed for "requests" (or incompatible with Python 3.8)

You may need to add a dependency for https://pypi.org/project/types-requests. Have not investigated this.

pyproject.toml Outdated Show resolved Hide resolved
@phillipskevin
Copy link
Author

Looks like CI is still failing after adding the types-requests dependency. I'll try to look into why.

@cretz
Copy link
Member

cretz commented Oct 15, 2024

Looks like it's still complaining on 3.8. I admittedly have not spent time digging into this.

@phillipskevin
Copy link
Author

Python 3.8 went end of life last week, so having some trouble testing it now. Will the versions used in CI be updated? Or will you continue to support 3.8 for some time?

@cretz
Copy link
Member

cretz commented Oct 15, 2024

I suspect we will EOL it too soon, though no specific timeline. EDIT: Opened temporalio/sdk-python#672 for dropping 3.8 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants