New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checksum check is not correct #101

Closed

PhilipMay opened this issue Dec 8, 2023 · 0 comments · Fixed by #103

Member

PhilipMay commented Dec 8, 2023

mltb2/mltb2/fasttext.py

Line 37 in 7f9cd4c

if not os.path.exists(model_full_path):

When the checksum check fails an exception is raised. This is good.

But the file is saved.
Next time when the code is executed again the checksum is not calculated again and it will not detect corruption.

PhilipMay linked a pull request

that will close this issue

Remove file after download of checksum is not correct. #103

Merged

PhilipMay closed this as completed in #103

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment