Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] aar-doc command unknown after installation #75

Closed
moritzrp opened this issue Oct 2, 2024 · 5 comments · Fixed by #76
Closed

[Bug] aar-doc command unknown after installation #75

moritzrp opened this issue Oct 2, 2024 · 5 comments · Fixed by #76
Labels
bug Something isn't working

Comments

@moritzrp
Copy link
Contributor

moritzrp commented Oct 2, 2024

Description

The documentation refers to the use of aar-doc after the installation. But there is no entry point for aar-doc. Instead, aar_doc has to be used.

Reproduction steps

  1. Create a fresh virtual environment
  2. pip install aar-doc
  3. aar-doc [OPTIONS] ROLE_PATH COMMAND [ARGS]...

Current Behavior

Result: aar-doc: command not found

Expected Behavior

aar-doc should be executed.

Additional information

version: aar-doc-1.2.0

@moritzrp moritzrp added the bug Something isn't working label Oct 2, 2024
@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Oct 2, 2024

It's aar_doc, with an underscore. I see that the docs are wrong here.. I'll fix them.

@moritzrp
Copy link
Contributor Author

moritzrp commented Oct 2, 2024

To keep it consistent with the package name I added an entry point for aar-doc. Could this be a solution instead?

@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Oct 2, 2024

Good question - I don't know if having both is a good idea from a linux-/shell-/convience standpoint.

@moritzrp
Copy link
Contributor Author

moritzrp commented Oct 2, 2024

That's fair. My two cents from user perspective: Having a command that is the same name as the package I just installed is the most convenient and expected behavior.

@rndmh3ro
Copy link
Collaborator

rndmh3ro commented Oct 4, 2024

Let's do a hyphen then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants