Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cbManager batch_size configurable #37

Closed
fgalan opened this issue Sep 14, 2022 · 3 comments
Closed

cbManager batch_size configurable #37

fgalan opened this issue Sep 14, 2022 · 3 comments

Comments

@fgalan
Copy link
Contributor

fgalan commented Sep 14, 2022

En la clase cbManager el tamaño de bloque es fijo: No es cierto, parámetro block_size el cbManager.

    # Block size is string chars (= bytes, with ASCII codification). This is calculated
    # for 800k (Orion max request size is 1MB,
    # see https://fiware-orion.readthedocs.io/en/master/user/known_limitations.html)
    # and it is not recommended to change it
    block_size = 800000

No obstante, surgen casos en los que puede ser necessario cambiarlo con lo que:

  • Se desharcodearia, moviendolo a un parámetro de inicialización del cbManager
  • La advertencia de que no se recomienda cambiarlo (que sigue siendo ciertoa, 800000 está bien para la mayoría de los casos) se movería a documentación.
@fgalan
Copy link
Contributor Author

fgalan commented Sep 14, 2022

No obstante, surgen casos en los que puede ser necessario

En concreto, algunas ETLs en la que las entidades son pequeñas, en 800kb entran miles, y hay atascos con las notificaciones.

@fgalan
Copy link
Contributor Author

fgalan commented Sep 15, 2022

Igual habría que permitir dos limites (uno por nº de entidades y nº de bytes) y que cerrara cada batch el que primero se alcance.

@rg2011 rg2011 mentioned this issue Dec 15, 2022
@fgalan fgalan changed the title cbManager block_size configurable cbManager batch_size configurable Dec 15, 2022
@fgalan
Copy link
Contributor Author

fgalan commented Dec 15, 2022

Se implemen batch_size para establecer límite de entidades en PR #43

@fgalan fgalan closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant