Doc/fix list indentation #2563
Merged
Doc/fix list indentation #2563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
develop is no longer the default branch for fiware-orion repository... could you redo the PR using master as base branch, please? Thanks! |
|
I didn't know that the base branch could be changed in a PR... I have always thought that in that case the PR needs to be closed, then another opened. Great! |
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the "two-spaces lists" into "four-spaces lists".
This PR is related to that the documentation generated in GitHub differs that the generated using Read The Docs. This occurs due to GFM accepts two spaces for creating a new level of indentation. Python-Markdown (mkdocs uses it) does not accepts this variant of markdown and it will not Python-Markdown/markdown#451. If you uses 4 spaces instead of two, both documents will be rendered properly.
We have compiled this PR in RTD so you can check it online at http://fiwareulpgcorion.readthedocs.io/en/doc-fix_list_indentation/user/ngsiv2_implementation_notes/index.html