Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please expand benchmarking #6

Closed
jdeligt opened this issue Feb 29, 2020 · 3 comments
Closed

Please expand benchmarking #6

jdeligt opened this issue Feb 29, 2020 · 3 comments
Labels

Comments

@jdeligt
Copy link

jdeligt commented Feb 29, 2020

In my encounters with bedtools there were quite some times when output was not correct due to ambiguities of 'when to count a read' (clipped bases, Quality of read vs base, etc.). It would be good to not only benchmark performance but also concordance.

The benchmark section could benefit from a statement of what tools were considered. i.e. Artem worked on a similar re-implementation of depth analysis in sambamba, sambamba-depth, was this tools considered for benchmarking?

@telatin
Copy link
Owner

telatin commented Mar 2, 2020

Thanks for the comment, we will exapand the benchmark page.

I didn't know about sambamba-depth, do you know if it has a method to output the stats in bed format? We can add it in any case using "sambamba depth base", but the output is definitely different (per base, indeed, even if the coverage is not changing)

@telatin telatin added the joss label Mar 2, 2020
@telatin
Copy link
Owner

telatin commented Mar 2, 2020

Documentation RE: Concordance

The Wiki has been expanded with further details on the coverage calculation, explaining potential differences with other tools. (https://github.com/telatin/covtobed/wiki/covtobed)

An output example has been added https://github.com/telatin/covtobed/tree/master/test/output including output from different tools.

@telatin
Copy link
Owner

telatin commented Mar 2, 2020

The benchmark page now has a preamble on the choice of tools, and a link to a comparison with sambamba-depth: https://github.com/telatin/covtobed/tree/master/benchmark#readme

@telatin telatin closed this as completed Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants