Spills styles over even when not active

[krassowski]

Hi @telamonian, just FYI, there is a strange issue with this theme (or all external themes? I do not know) which results in some styles being active even if the theme is not active: https://stackoverflow.com/questions/67870994/change-the-mouse-select-color-in-jupyterlab-3

Even more strange is that simply disabling it via jupyter labextension disable @telamonian/theme-darcula did not work for me, I had to uninstall it completely with pip uninstall theme-darcula to get rid of the issue (but maybe this is a federated extensions thing).

[telamonian]

well that sounds like a horrible bug.

A) what browser?

B) have you tested this out with any other theme?

[krassowski]

A) The user who reported it on Stack Overflow used, quote:

Jupyter lab is version v3.0.16. The complete stack is Jupyterhub with dockerspawner on Ubuntu 20.04.2. I am using Google Chrome browser on Win 10, the same problem happens in Edge

I verified it locally on Google Chrome.

B) I did not - don't use themes other than the built-in ones.

[krassowski]

It seems to be coming from https://github.com/telamonian/theme-darcula/blob/master/style/codemirror-darcula.css and the comment in there:

theme-darcula/style/codemirror-darcula.css

Lines 6 to 8 in ff24101

	/*
	* Codemirror styling that isn't currently supported by Jupyterlab themes
	*/

Makes me suspect it might be the culprit.

[telamonian]

yeah that's the source, but the entire stylesheet should get unloaded on theme switch. Something's getting in the way

[jtpio]

@telamonian @krassowski should we move this conversation to the lab issue? jupyterlab/jupyterlab#10378

It seems to also be affecting the miami nights theme (linked in the issue), so probably the issue is related to federated theme extensions in general?

[jasongrout]

Fix over in #33