From 51df96b97da8a52dc6a3d528facfbc5183c3f9cd Mon Sep 17 00:00:00 2001 From: esarver Date: Wed, 20 Nov 2024 08:59:58 -0500 Subject: [PATCH] Stack Overflow Exception Fix (#75) There was a stack overflow exception because I missed changing a member variable name after I added a getter for it. Additionally: Use the non-incrementing progress bar instead of one that shows progress since we don't know how long certain steps will take. --- src/resourceManager.ts | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/resourceManager.ts b/src/resourceManager.ts index 45b787a..36d698a 100644 --- a/src/resourceManager.ts +++ b/src/resourceManager.ts @@ -224,7 +224,7 @@ export class KicProcessMgr { } public get kicList(): Array { - return this.kicList + return this._kicList } /** @@ -396,7 +396,6 @@ export class KicCell extends EventEmitter { .get("dumpQueueOnConnect") ) { progress.report({ - increment: 0, message: "Dumping data from instrument output queue", }) Log.info( @@ -427,7 +426,6 @@ export class KicCell extends EventEmitter { } progress.report({ - increment: 37, message: "Getting instrument information", }) Log.trace("Getting instrument information", LOGLOC) @@ -495,7 +493,6 @@ export class KicCell extends EventEmitter { } progress.report({ - increment: 10, message: `Connecting to instrument with model ${_info.model} and S/N ${_info.serial_number}`, }) @@ -559,7 +556,6 @@ export class KicCell extends EventEmitter { Log.trace(`Connected to ${info.trim()}`, LOGLOC) progress.report({ - increment: 53, message: `Connected to instrument with model ${_info.model} and S/N ${_info.serial_number}`, }) return new Promise((resolve) => resolve([info, verified_name]))