Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to using reusable workflows from the tektronix/python-package-ci-cd repo #284

Merged
merged 7 commits into from
Aug 27, 2024

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Aug 27, 2024

Proposed changes

This converts almost all workflows to use reusable workflows from the tektronix/python-package-ci-cd repo.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have created (or updated) an Issue to track the status of this update/change and updated the link in this PR description (see above in the Proposed changes section) using the wording Addresses #<issue_number>
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 requested a review from a team as a code owner August 27, 2024 16:56
@tek-githubbot-1010 tek-githubbot-1010 requested a review from a team August 27, 2024 16:56
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7e97cc3) to head (e6980c5).
Report is 49 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #284   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          152       152           
  Lines         4879      4879           
  Branches       779       779           
=========================================
  Hits          4879      4879           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfelt14 nfelt14 enabled auto-merge (squash) August 27, 2024 17:59
@nfelt14 nfelt14 disabled auto-merge August 27, 2024 17:59
@nfelt14 nfelt14 enabled auto-merge (squash) August 27, 2024 18:04
@nfelt14 nfelt14 disabled auto-merge August 27, 2024 18:41
Copy link
Collaborator Author

@nfelt14 nfelt14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to pin workflows to a version

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Aug 27, 2024

Need to pin workflows to a version

All workflows have been pinned to v1.0.0

@nfelt14 nfelt14 enabled auto-merge (squash) August 27, 2024 20:01
Copy link

github-actions bot commented Aug 27, 2024

Test Results (windows)

path passed subtotal
tests\test_afgs.py 2 2
tests\test_alias_dict.py 1 1
tests\test_all_device_drivers.py 1 1
tests\test_alternative_connection_addresses.py 19 19
tests\test_awgs.py 4 4
tests\test_config_parser.py 38 38
tests\test_device_manager.py 17 17
tests\test_devices_legacy_tsp_ieee_cmds.py 3 3
tests\test_extension_mixin.py 1 1
tests\test_generate_waveform.py 6 6
tests\test_helpers.py 72 72
tests\test_ieee_scpi_cmds.py 1 1
tests\test_margin_testers.py 5 5
tests\test_pi_device.py 1 1
tests\test_psu.py 1 1
tests\test_rest_api_device.py 10 10
tests\test_scopes.py 8 8
tests\test_singleton.py 1 1
tests\test_smu.py 4 4
tests\test_ss.py 1 1
tests\test_tm_devices.py 5 5
tests\test_unsupported_device_type.py 1 1
TOTAL 202 202

Link to workflow run

Copy link

github-actions bot commented Aug 27, 2024

Test Results (macos)

path passed subtotal
tests/test_afgs.py 2 2
tests/test_alias_dict.py 1 1
tests/test_all_device_drivers.py 1 1
tests/test_alternative_connection_addresses.py 19 19
tests/test_awgs.py 4 4
tests/test_config_parser.py 38 38
tests/test_device_manager.py 17 17
tests/test_devices_legacy_tsp_ieee_cmds.py 3 3
tests/test_extension_mixin.py 1 1
tests/test_generate_waveform.py 6 6
tests/test_helpers.py 72 72
tests/test_ieee_scpi_cmds.py 1 1
tests/test_margin_testers.py 5 5
tests/test_pi_device.py 1 1
tests/test_psu.py 1 1
tests/test_rest_api_device.py 10 10
tests/test_scopes.py 8 8
tests/test_singleton.py 1 1
tests/test_smu.py 4 4
tests/test_ss.py 1 1
tests/test_tm_devices.py 5 5
tests/test_unsupported_device_type.py 1 1
TOTAL 202 202

Link to workflow run

Copy link

github-actions bot commented Aug 27, 2024

Test Results (ubuntu)

path passed subtotal
tests/test_afgs.py 2 2
tests/test_alias_dict.py 1 1
tests/test_all_device_drivers.py 1 1
tests/test_alternative_connection_addresses.py 19 19
tests/test_awgs.py 4 4
tests/test_config_parser.py 38 38
tests/test_device_manager.py 17 17
tests/test_devices_legacy_tsp_ieee_cmds.py 3 3
tests/test_extension_mixin.py 1 1
tests/test_generate_waveform.py 6 6
tests/test_helpers.py 72 72
tests/test_ieee_scpi_cmds.py 1 1
tests/test_margin_testers.py 5 5
tests/test_pi_device.py 1 1
tests/test_psu.py 1 1
tests/test_rest_api_device.py 10 10
tests/test_scopes.py 8 8
tests/test_singleton.py 1 1
tests/test_smu.py 4 4
tests/test_ss.py 1 1
tests/test_tm_devices.py 5 5
tests/test_unsupported_device_type.py 1 1
TOTAL 202 202

Link to workflow run

@nfelt14 nfelt14 merged commit 266e6b6 into tektronix:main Aug 27, 2024
65 checks passed
@nfelt14 nfelt14 deleted the use-tektronix-reusable-workflows branch August 27, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants