From a8dfdaf9d08701bb6bf70bbe04938249c5e54db1 Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Fri, 22 Sep 2023 19:37:57 -0700 Subject: [PATCH 1/8] ci: Use new workflow for assigning reviewers. --- .github/auto_request_review.yml | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .github/auto_request_review.yml diff --git a/.github/auto_request_review.yml b/.github/auto_request_review.yml new file mode 100644 index 00000000..efa23d40 --- /dev/null +++ b/.github/auto_request_review.yml @@ -0,0 +1,7 @@ +--- +reviewers: + defaults: + - {team: tm-devices-maintainers} +options: + ignore_draft: true + enable_group_assignment: true From 02eb0607f881ba88d74bf6026ac2e6a78647897a Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Fri, 22 Sep 2023 19:40:12 -0700 Subject: [PATCH 2/8] ci: Assign reviewers on all PR types --- .github/auto_request_review.yml | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 .github/auto_request_review.yml diff --git a/.github/auto_request_review.yml b/.github/auto_request_review.yml deleted file mode 100644 index efa23d40..00000000 --- a/.github/auto_request_review.yml +++ /dev/null @@ -1,7 +0,0 @@ ---- -reviewers: - defaults: - - {team: tm-devices-maintainers} -options: - ignore_draft: true - enable_group_assignment: true From 9b205949b31cc934ddb825a1ceb5b34e69bceea8 Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Sat, 23 Sep 2023 16:31:31 -0700 Subject: [PATCH 3/8] ci: Add steps to verify package can be installed from test.pypi.org and pypi.org after uploading it. --- .github/workflows/package-build.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/package-build.yml b/.github/workflows/package-build.yml index c0679d32..f9103628 100644 --- a/.github/workflows/package-build.yml +++ b/.github/workflows/package-build.yml @@ -43,6 +43,14 @@ jobs: uses: pypa/gh-action-pypi-publish@v1.8.8 with: repository-url: https://test.pypi.org/legacy/ + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: x # any version + check-latest: true + - name: Test installing from test.pypi.org + run: pip install --index-url=https://test.pypi.org/simple/ --extra-index-url=https://pypi.org/simple + tm_devices # Upload to PyPI and create a tag in the repo after a GitHub Release is published pypi: @@ -66,3 +74,10 @@ jobs: run: |- git tag --annotate v${{ github.event.release.tag_name }} --message="${{ github.event.release.name }}" git push --tags + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: x # any version + check-latest: true + - name: Test installing from pypi.org + run: pip install tm_devices From a203ade2f9b5a097f53fe10be5263348251ac149 Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Fri, 22 Sep 2023 19:37:57 -0700 Subject: [PATCH 4/8] ci: Use new workflow for assigning reviewers. --- .github/auto_request_review.yml | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 .github/auto_request_review.yml diff --git a/.github/auto_request_review.yml b/.github/auto_request_review.yml new file mode 100644 index 00000000..efa23d40 --- /dev/null +++ b/.github/auto_request_review.yml @@ -0,0 +1,7 @@ +--- +reviewers: + defaults: + - {team: tm-devices-maintainers} +options: + ignore_draft: true + enable_group_assignment: true From 14603f917c2f11cf5bad8c6bc3b19944d317e1fc Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Fri, 22 Sep 2023 19:40:12 -0700 Subject: [PATCH 5/8] ci: Assign reviewers on all PR types --- .github/auto_request_review.yml | 7 ------- 1 file changed, 7 deletions(-) delete mode 100644 .github/auto_request_review.yml diff --git a/.github/auto_request_review.yml b/.github/auto_request_review.yml deleted file mode 100644 index efa23d40..00000000 --- a/.github/auto_request_review.yml +++ /dev/null @@ -1,7 +0,0 @@ ---- -reviewers: - defaults: - - {team: tm-devices-maintainers} -options: - ignore_draft: true - enable_group_assignment: true From e63bbc4c6cfca7637cbdc9adf4f22e6bb6f104d0 Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Thu, 28 Sep 2023 10:03:34 -0700 Subject: [PATCH 6/8] docs: Update order of badges in readme. --- README.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.rst b/README.rst index 93909fab..4f23f998 100644 --- a/README.rst +++ b/README.rst @@ -21,7 +21,7 @@ * - Documentation - |Documentation status| * - Code Style - - |Code style: black| |Test style: pytest| |Imports: isort| |Docstring style: google| + - |Test style: pytest| |Code style: black| |Imports: isort| |Docstring style: google| * - Linting - |pre-commit enabled| |Docstring formatter: docformatter| |Type Checker: pyright| |Linter: pylint| |Linter: Ruff| @@ -237,7 +237,7 @@ Supported Connections Documentation ------------- -See the full documentation at https://tm_devices.readthedocs.io +See the full documentation at ``__ Maintainers ----------- From 257e7d2519b2ee086e30189bfbc5653e863e9ba6 Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Thu, 28 Sep 2023 13:58:29 -0700 Subject: [PATCH 7/8] ci: Add test for installing wheel and tarball to the build package workflow. --- .github/workflows/package-build.yml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/workflows/package-build.yml b/.github/workflows/package-build.yml index f9103628..2e96056e 100644 --- a/.github/workflows/package-build.yml +++ b/.github/workflows/package-build.yml @@ -25,6 +25,20 @@ jobs: with: fetch-depth: 0 - uses: hynek/build-and-inspect-python-package@v1.5 + id: build-pkg + - name: Set up Python + uses: actions/setup-python@v4 + with: + python-version: x # any version + check-latest: true + - name: Test installing wheel + run: | + pip install ${{ steps.build-pkg.outputs.dist }}/*.whl + pip uninstall --yes tm_devices + - name: Test installing tarball + run: | + pip install ${{ steps.build-pkg.outputs.dist }}/*.tar.gz + pip uninstall --yes tm_devices # Upload to Test PyPI on every push to main test-pypi: From d7b1a73710ed37d7c42e7b524f051448f3806218 Mon Sep 17 00:00:00 2001 From: Nicholas Felt Date: Fri, 29 Sep 2023 13:56:48 -0700 Subject: [PATCH 8/8] build: Update package author to allow package upload. --- README.rst | 2 +- pyproject.toml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.rst b/README.rst index 4f23f998..cc1099a3 100644 --- a/README.rst +++ b/README.rst @@ -242,7 +242,7 @@ See the full documentation at ``__ Maintainers ----------- -- Tektronix https://pypi.org/user/Tektronix/ +- Tektronix opensource@tektronix.com - Nicholas Felt nicholas.felt@tektronix.com Contributing diff --git a/pyproject.toml b/pyproject.toml index 67f11081..e8f28352 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -43,7 +43,7 @@ mypy_path = "./src/" [tool.poetry] authors = [ - "Tektronix ", + "Tektronix ", "Nicholas Felt " ] classifiers = [ @@ -68,7 +68,7 @@ keywords = [ ] license = "Apache License 2.0" maintainers = [ - "Tektronix ", + "Tektronix ", "Nicholas Felt " ] name = "tm_devices"