Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated the custom styling for the badge table in the readme to make sure the badges are spaced vertically properly. #79

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 28, 2023

Proposed changes

Update the badge table to look better when built with sphinx.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

… make sure the badges are spaced vertically properly.
@nfelt14 nfelt14 requested a review from a team as a code owner October 28, 2023 15:13
@nfelt14 nfelt14 temporarily deployed to package-build October 28, 2023 15:13 — with GitHub Actions Inactive
@nfelt14 nfelt14 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 28, 2023
@nfelt14 nfelt14 requested a review from a team October 28, 2023 15:13
@nfelt14 nfelt14 enabled auto-merge (squash) October 28, 2023 15:14
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Merging #79 (cb85a66) into main (554d75b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #79   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3761      3761           
  Branches       644       644           
=========================================
  Hits          3761      3761           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14

This comment was marked as duplicate.

@nfelt14
Copy link
Collaborator Author

nfelt14 commented Oct 28, 2023

Final version looks like this:

image

Previous version looked like this:

image

@nfelt14 nfelt14 temporarily deployed to package-build October 30, 2023 17:22 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-build October 30, 2023 18:13 — with GitHub Actions Inactive
@nfelt14 nfelt14 merged commit 3dcab2c into main Oct 30, 2023
35 checks passed
@nfelt14 nfelt14 deleted the nfelt14/fix-badge-spacing-in-readme branch October 30, 2023 18:15
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 15, 2024
… make sure the badges are spaced vertically properly. (tektronix#79)

Signed-off-by: qthompso <[email protected]>
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 16, 2024
… make sure the badges are spaced vertically properly. (tektronix#79)
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
… make sure the badges are spaced vertically properly. (tektronix#79)

Signed-off-by: v12ganesh [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants