Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated comment #71

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

michaelwagoner
Copy link
Contributor

@michaelwagoner michaelwagoner commented Oct 25, 2023

Proposed changes

Please include a summary of the changes and any links to related issues. Please also include relevant motivation and context.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@michaelwagoner michaelwagoner requested a review from a team as a code owner October 25, 2023 23:39
@michaelwagoner michaelwagoner temporarily deployed to package-build October 25, 2023 23:39 — with GitHub Actions Inactive
@nfelt14 nfelt14 requested a review from a team October 25, 2023 23:39
@michaelwagoner michaelwagoner enabled auto-merge (squash) October 25, 2023 23:40
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #71 (ae943d0) into main (c8a5cec) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #71   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3761      3761           
  Branches       644       644           
=========================================
  Hits          3761      3761           
Files Coverage Δ
.../tm_devices/drivers/pi/scopes/tekscope/tekscope.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michaelwagoner michaelwagoner merged commit 7be155d into tektronix:main Oct 26, 2023
35 checks passed
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 15, 2024
qthompso pushed a commit to qthompso/tm_devices that referenced this pull request Feb 16, 2024
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants