Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test.pypi.org upload workflow #25

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Update test.pypi.org upload workflow #25

merged 6 commits into from
Oct 11, 2023

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Oct 11, 2023

Proposed changes

The workflow that uploads to test.pypi.org needed to be refactored and split up to limit elevated permission usage.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Functionality update (non-breaking change which updates or changes existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • CI/CD update (an update to the CI/CD workflows, scripts, and/or configurations)
  • Documentation update (an update to enhance the user experience when reading through the docs)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

@nfelt14 nfelt14 temporarily deployed to package-build October 11, 2023 15:04 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-testpypi October 11, 2023 15:06 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #25 (127b14c) into main (e7734d7) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          168       168           
  Lines         3756      3756           
  Branches       646       646           
=========================================
  Hits          3756      3756           
Files Coverage Δ
.../tm_devices/drivers/pi/scopes/tekscope/tekscope.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nfelt14 nfelt14 temporarily deployed to package-build October 11, 2023 15:09 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-testpypi October 11, 2023 15:11 — with GitHub Actions Inactive
tests/test_device_manager.py Dismissed Show resolved Hide resolved
@nfelt14 nfelt14 temporarily deployed to package-build October 11, 2023 15:22 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-testpypi October 11, 2023 15:23 — with GitHub Actions Inactive
@nfelt14 nfelt14 temporarily deployed to package-build October 11, 2023 15:27 — with GitHub Actions Inactive
@nfelt14 nfelt14 marked this pull request as ready for review October 11, 2023 15:31
@nfelt14 nfelt14 requested a review from a team as a code owner October 11, 2023 15:31
@nfelt14 nfelt14 requested a review from a team October 11, 2023 15:32
@nfelt14 nfelt14 added enhancement New feature or request ci/cd Improvements or additions to the CI/CD process labels Oct 11, 2023
@nfelt14 nfelt14 enabled auto-merge (squash) October 11, 2023 15:41
@nfelt14 nfelt14 merged commit ab093ad into main Oct 11, 2023
35 checks passed
@nfelt14 nfelt14 deleted the nfelt14/misc-updates branch October 11, 2023 16:19
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
* fix: Update some type-hinting directive comments.

* ci: Refactored the test.pypi.org upload workflow to have separate sections to limit elevated permissions usage.

* ci: Add a retry to the installation step to let the package become available on the index server.
Signed-off-by: v12ganesh ganesh.v@tektronix.com
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Improvements or additions to the CI/CD process enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants