Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update the function that detects a VISA resource expression to work properly for SOCKET resource expressions. #134

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

nfelt14
Copy link
Collaborator

@nfelt14 nfelt14 commented Jan 30, 2024

Proposed changes

Update the resource expression detection function to properly handle SOCKET VISA resource expression strings. Also update the DeviceManager to be able to handle them.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have followed the guidelines in the CONTRIBUTING document
  • I have signed the CLA
  • I have checked to ensure there aren't other open Pull Requests for the same update/change
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • Basic linting passes locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have added necessary documentation (if appropriate)
  • I have updated the Changelog with a brief description of my changes

…ork properly for SOCKET resource expressions.
@nfelt14 nfelt14 requested review from a team as code owners January 30, 2024 16:49
@nfelt14 nfelt14 enabled auto-merge (squash) January 30, 2024 16:51
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1602ca7) 100.00% compared to head (32dfe57) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #134   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          170       170           
  Lines         3793      3796    +3     
  Branches       655       657    +2     
=========================================
+ Hits          3793      3796    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nfelt14 nfelt14 merged commit 4467e14 into main Jan 30, 2024
36 checks passed
@nfelt14 nfelt14 deleted the nfelt14/allow-socket-resource-strings branch January 30, 2024 20:35
v12ganesh pushed a commit to v12ganesh/tm_devices that referenced this pull request Mar 28, 2024
…ork properly for SOCKET resource expressions. (tektronix#134)

Signed-off-by: v12ganesh [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Unable to connect to the Oscilloscope through Socket port using a VISA Resource string
2 participants