-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unscheduled Runs shouldn't be included in full status #5294
Conversation
Fixes tektoncd#5282 When removing conditions, I accidentally made `GetRunsStatus` not skip including custom task `ResolvedPipelineTask`s without `Run`s in the `PipelineRun.Status.Runs` map. This resulted in cancellation failing, because the cancellation logic tries to patch each `Run` or `TaskRun` in the `PipelineRun` status (either in the `Runs` and `TaskRuns` maps for full embedded status, or `ChildReferences` for minimal or both embedded status). Unscheduled `PipelineTask`s for `Task`s were already properly excluded from the status map, and `ChildReferences` was fine either way, but due to the oversight I mentioned above, unscheduled `PipelineTask`s for custom tasks _were_ included in the full embedded status map, and cancellation would error due to that. Signed-off-by: Andrew Bayer <[email protected]>
The following is the coverage report on the affected files.
|
@afrittoli: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
#5295 fixes the test failures - they're happening because in v0.37.x, we were including custom tasks (but not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pritidesai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Cherry-pick #5287 on v0.37.x
Changes
Fixes #5282
When removing conditions, I accidentally made
GetRunsStatus
not skip including custom taskResolvedPipelineTask
s withoutRun
s in thePipelineRun.Status.Runs
map. This resulted in cancellation failing, because the cancellation logic tries to patch eachRun
orTaskRun
in thePipelineRun
status (either in theRuns
andTaskRuns
maps for full embedded status, orChildReferences
for minimal or both embedded status). UnscheduledPipelineTask
s forTask
s were already properly excluded from the status map, andChildReferences
was fine either way, but due to the oversight I mentioned above, unscheduledPipelineTask
s for custom tasks were included in the full embedded status map, and cancellation would error due to that.Signed-off-by: Andrew Bayer [email protected]
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
/kind <type>
. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes
/kind bug