Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated regex pattern to allow all three valid bracket notations. #4811

Closed
wants to merge 4 commits into from
Closed

Updated regex pattern to allow all three valid bracket notations. #4811

wants to merge 4 commits into from

Commits on Apr 28, 2022

  1. Added a unit test for pod status. 

    Add unit test with large result for setTaskRunStatusBasedOnStepStatus.
    @chitrangpatel
    chitrangpatel committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    2b55a4a View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2022

  1. Updated regex pattern to allow all three valid bracket notations. 

    Prior to this, when supplied parameter name was not the same as that
called in the step, webhook raised an error when using the dot notation
as expected. However, it did not when using the bracket notation.

Updated the unit tests to also check for valid bracket notations.
    @chitrangpatel
    chitrangpatel committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    dba064d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'tektoncd:main' into main

    @chitrangpatel
    chitrangpatel authored Apr 29, 2022
    Configuration menu
    Copy the full SHA
    3bc5be8 View commit details
    Browse the repository at this point in the history

  3. merged origin main

    @chitrangpatel
    chitrangpatel committed Apr 29, 2022
    Configuration menu
    Copy the full SHA
    cb4f19b View commit details
    Browse the repository at this point in the history