Implementation details for results emitting in TEP-0076

[Yongxuanzhang]

Feature request

This is part of #4723 area 2.

Right now the results are written to /tekton/results/resultname file, and the content will be read and stored as string in v1beta1.PipelineResourceResult 's value, later it will be written to termination message.

To support array and later object type for results. I suggest we change the type of
v1beta1.PipelineResourceResult.Value from string to v1beta1.ArrayOrString, and when we read the bytes from results file we can check and unmarshal them into v1beta1.ArrayOrString.

The pro of this is that the json marshal and unmarshal will be easier when handling results data.

This can be done here

pipeline/pkg/entrypoint/entrypointer.go

Lines 197 to 212 in 68f2a66

	for _, resultFile := range e.Results {
	if resultFile == "" {
	continue
	}
	fileContents, err := ioutil.ReadFile(filepath.Join(pipeline.DefaultResultPath, resultFile))
	if os.IsNotExist(err) {
	continue
	} else if err != nil {
	return err
	}
	// if the file doesn't exist, ignore it
	output = append(output, v1beta1.PipelineResourceResult{
	Key: resultFile,
	Value: string(fileContents),
	ResultType: v1beta1.TaskRunResultType,
	})

For later json schema validation, as suggested by @ywluogg, we can validate later here, since we can easily get the taskspec.

pipeline/pkg/pod/status.go

Lines 224 to 232 in 68f2a66

	for _, r := range results {
	switch r.ResultType {
	case v1beta1.TaskRunResultType:
	taskRunResult := v1beta1.TaskRunResult{
	Name: r.Key,
	Value: r.Value,
	}
	taskResults = append(taskResults, taskRunResult)
	filteredResults = append(filteredResults, r)

Use case

[Yongxuanzhang]

/assign

[tekton-robot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

[Yongxuanzhang]

Already done