-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Invalid log format" error in e2e tests with logstream #4777
Comments
I think this is worth doing in the config as well as in tests since it helps cut down on log spam when debugging. |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/lifecycle frozen |
Is there a downside to updating our config-logging.yaml to match logstream's expectations? Installations and their monitoring that had previously looked for In any case, #5159 seems to be one way to fix this issue. |
When running e2e tests, logstream barfs when trying to take the JSON log entries fed to it and turn them into more readable lines, like this:
This is because logstream changed the keys it's expecting to fit a knative/pkg change, with the result that logstream is expecting
severity
, notlevel
,timestamp
, notts
, andmessage
, notmsg
. Ourconfig-logging
still uses the "old" keys.The question, as I see it, is whether we should update
config/config-logging.yaml
to use the same keys as Knative and logstream, or if we should specifically hack the e2e test setup to use those keys instead./kind bug
The text was updated successfully, but these errors were encountered: