Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can the "place-tools" and "place-scripts" init-containers merge into one init-container? #4519

Open
Tomcli opened this issue Jan 26, 2022 · 5 comments
Assignees
Labels
area/performance Issues or PRs that are related to performance aspects. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@Tomcli
Copy link
Contributor

Tomcli commented Jan 26, 2022

Feature request

Our team is trying to optimize our Tekton pipelines to have fewer delays. We found out that many Tekton tasks need to run the "place-tools" and "place-scripts" init-containers to set all the Tekton tools and wrap the user scripts. Since some of our machines may have slow container startup time, we want to see can these init-containers merge into one so we can save 1-2s in each of our tasks.

/cc @pritidesai @afrittoli

Use case

@Tomcli Tomcli added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2022
@pritidesai
Copy link
Member

@rafalbigaj reported, for about 26 seconds of workload, initiating place-tools container is causing an average of 2 seconds of delay after the image is pulled from the container registry.

@jerop jerop added the area/performance Issues or PRs that are related to performance aspects. label Jan 31, 2022
@afrittoli
Copy link
Member

#4352 introduced a new init container.
If we are going to merge the various init containers into one, we might consider including that one too.

@abayer
Copy link
Contributor

abayer commented May 4, 2022

/assign @vdemeester

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 2, 2022
@vdemeester
Copy link
Member

/lifecycle frozen
Still planning to work on this 👼🏼

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/performance Issues or PRs that are related to performance aspects. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Todo
Development

No branches or pull requests

7 participants