Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there any way to tell whether any of the finally tasks failed? #3715

Closed
riceluxs1t opened this issue Jan 25, 2021 · 4 comments · Fixed by #4121
Closed

Is there any way to tell whether any of the finally tasks failed? #3715

riceluxs1t opened this issue Jan 25, 2021 · 4 comments · Fixed by #4121
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@riceluxs1t
Copy link

I have a pipeline that has
task1 -> task 2 -> ... -> taskN | singleFinallyTask.

When singleFinallyTask fails for whatever reasons, is there an easy way to use kubectl or tkn to tell?

@chmouel
Copy link
Member

chmouel commented Jan 26, 2021

I believe there is a TEP in the work for this :

tektoncd/community#240

In the meantime this gets discussed/implemented, I have done something like this to get slack notifications, the main code detection is here which returns the list of the failed tasks :

https://github.com/chmouel/tekton-asa-code/blob/47bd39d/misc/send-slack-notifications.py#L37-L57

You can get the current pipelinerun that is executing in a environement variable of a task like this :

https://github.com/chmouel/tekton-asa-code/blob/47bd39d/README.md#L287-L290

Not straightforward, but hopefully the TEP would make all of this obsolete and easier to work with results.

/kind question

@tekton-robot tekton-robot added the kind/question Issues or PRs that are questions around the project or a particular feature label Jan 26, 2021
@pritidesai
Copy link
Member

@riceluxs1t would tagging taskRun of singleFinallyTask help your use case? We could classify taskRun created for finally tasks by adding a label to it. (something similar to #3721).

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2021
@pritidesai
Copy link
Member

We do not have any solution to this yet.
/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 27, 2021
@dibyom dibyom added kind/feature Categorizes issue or PR as related to a new feature. and removed kind/question Issues or PRs that are questions around the project or a particular feature labels May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants