Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to set "displayName" for Pipeline tasks #3466

Closed
itewk opened this issue Oct 28, 2020 · 15 comments · Fixed by #6294
Closed

add ability to set "displayName" for Pipeline tasks #3466

itewk opened this issue Oct 28, 2020 · 15 comments · Fixed by #6294
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@itewk
Copy link

itewk commented Oct 28, 2020

Feature request

Currently when a pipeline is rendered in the UI the Pipeline.tasks.*.name is used in the UI. The problem is that field has character requirments on it designed for a machine so it can be used for other params like runAfter. This means that the pipelines are not very human readable in the UI.

Use case

For instance when converting a pipeline from Jenkins to Tekton. had a Jenkins stage named CI: Static Image Scan: Compliance in tekton i have to name the task ci-static-image-scan-compliance and that is what gets rendered in the UI for end users rather then something nice a pretty like in jenkins.

Solution

Need a new filed, such as Pipeline.tasks.*.displayName which is optional and allows a human readable text that gets rendered in the UI if supplied instead of Pipeline.tasks.*.name.

@itewk itewk added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 28, 2020
@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2021
@itewk
Copy link
Author

itewk commented Jan 26, 2021

:(

@imjasonh
Copy link
Member

/remove-lifecycle stale

This seems like a fairly straightforward FR, possibly even a [good first issue]. I think a TEP is a good next step, to get feedback and input from the community, particularly in the CLI and Dashboard areas.

If you're interested in drafting a brief TEP I can help shepherd this through the process. 👍

@tekton-robot tekton-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2021
@itewk
Copy link
Author

itewk commented Jan 26, 2021

ill need a a definition of TEP, but happy to help push it along

@imjasonh
Copy link
Member

The TEP (Tekton Enhancement Proposal) process is described here: https://github.com/tektoncd/community/blob/master/teps/0001-tekton-enhancement-proposal-process.md

Basically, write up a short Markdown document using the template, send a PR to tektoncd/community, people will discuss and (🤞) approve, then we can implement.

Since the proposal is small, just adding a field, I suspect discussion will be light, but it helps get visibility from other teams before making changes that might affect them.

@itewk
Copy link
Author

itewk commented Jan 26, 2021

@imjasonh tektoncd/community#319

@tekton-robot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 26, 2021
@itewk
Copy link
Author

itewk commented Apr 26, 2021

@imjasonh the TEP got merged, should this stay alive for the actual implementation or allowed to die?

@imjasonh
Copy link
Member

/lifecycle frozen

Let's keep it open.

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2021
@jerop jerop added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Feb 17, 2023
@jerop
Copy link
Member

jerop commented Feb 17, 2023

TEP-0047: Pipeline Task Display Name is implementable - we welcome contributions in implementing it

@nanjingfm
Copy link
Contributor

/assign

@jerop
Copy link
Member

jerop commented Mar 29, 2023

Thank you @nanjingfm for implementing this feature!

Could you please update the status of TEP-0047, and add a link to the implementation PR? 🙏🏾

@nanjingfm
Copy link
Contributor

Here is the pr marking tep-0047 as implemented. 😁

@Goltergaul
Copy link

is this supported by the dashboard?

@pritidesai
Copy link
Member

Yes, this is supported by the dashboard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

7 participants