Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add support for corporate proxies (e.g. in the git PipelineResource) #1663

Closed
jomeier opened this issue Dec 2, 2019 · 10 comments · Fixed by #2215
Closed
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. maybe-next-milestone For consideration when planning the next milestone priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@jomeier
Copy link

jomeier commented Dec 2, 2019

Hi,

I'm testing Tekton pipelines in OpenShift4 (OKD4) behind our corporate proxy.

Today I stumbled over Tekton not respecting HTTPS_PROXY environment variables while cloning git repositories in the git PipelineResources.

I'm not able to clone anything.

It would be great If we could define the common proxy env variables in a suited location (maybe as a secret or as environment variables in the Pipeline CR).

Typically the variables are:

  • HTTPS_PROXY
  • HTTP_PROXY
  • https_proxy
  • http_proxy
  • NO_PROXY
  • no_proxy

Go code should be aware of proxy env variables.

This feature request would make Tekton more suitable for enterprise environments where proxies arent unusual.

Thanks and greetings,

Josef

@imjasonh
Copy link
Member

imjasonh commented Dec 2, 2019

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 2, 2019
@imjasonh imjasonh added this to the Pipelines 0.10 🐱 milestone Dec 2, 2019
@wlynch
Copy link
Member

wlynch commented Dec 2, 2019

As @imjasonh mentioned in slack, we should probably have the ability to set arbitrary variables, since there's also many more environment variables someone may want to set (in particular, I find that GIT_CURL_VERBOSE is a very useful tool for finding out why you might be getting permission denied when cloning).

@chmouel
Copy link
Member

chmouel commented Dec 3, 2019

Related #1476 #1328 #1294 #1606

@bobcatfish
Copy link
Collaborator

@imjasonh I notice you added this to the 0.10 milestone but we're trying to make sure we're really sparing about what we add to the milsetone so I'm gonna remove it for now but lemme know if you strongly disagree!

@bobcatfish bobcatfish removed this from the Pipelines 0.10 🐱 milestone Dec 20, 2019
@jomeier
Copy link
Author

jomeier commented Dec 25, 2019

@bobcatfish
Without support for corporate proxies, Tekton will be unusable in lots of corporate environments.

@chmouel
Copy link
Member

chmouel commented Dec 26, 2019

Strong +1 on this too...

@jomeier
Copy link
Author

jomeier commented Jan 23, 2020

Any news when this will be available? Tekton doesn't work in OpenShift behind corporate proxies because of that.

@dsanchor
Copy link

+1 here. Support for corporate proxies is a must in 99% of production environments. Still version 0.x, but this should be part of 1.x version.

@dvetto
Copy link

dvetto commented Feb 4, 2020

+1 . Same problem.

@dibyom dibyom added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. maybe-next-milestone For consideration when planning the next milestone labels Feb 5, 2020
@pritidesai
Copy link
Member

/assign pritidesai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. maybe-next-milestone For consideration when planning the next milestone priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants