From 0c92d1988574b244f48e98553e5a0cd9caae48ed Mon Sep 17 00:00:00 2001 From: Christie Wilson Date: Tue, 5 Feb 2019 17:17:34 -0800 Subject: [PATCH] =?UTF-8?q?Fix=20README=20and=20examples=20=F0=9F=98=85?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit I tried to run the examples this morning and found that the docs were wrong and also that the path in the example pipelines was now incorrect. I can see how the docs could get out of sync but something odd is happening with the pipeline paths b/c our tests should be catching that, so I'll open a bug. In the meantime, these changes make it so we can at least successfully create the pipelinerun (also tried the taskrun, which works - I haven't tried the other examples). --- examples/README.md | 8 ++++---- examples/pipeline.yaml | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/examples/README.md b/examples/README.md index 8eee73bb95d..7144e9eba49 100644 --- a/examples/README.md +++ b/examples/README.md @@ -10,16 +10,16 @@ To deploy them to your cluster (after kubectl apply -f examples/ # To invoke the build-push Task only -kubectl apply -f examples/run/task-run.yaml +kubectl apply -f examples/run/taskrun.yaml # To invoke the simple Pipeline -kubectl apply -f examples/run/pipeline-run.yaml +kubectl apply -f examples/run/pipelinerun.yaml # To invoke the Pipeline that links outputs -kubectl apply -f examples/run/output-pipeline-run.yaml +kubectl apply -f examples/run/output-pipelinerun.yaml # To invoke the TaskRun with embedded Resource spec and task Spec -kubectl apply -f examples/run/task-run-resource-spec.yaml +kubectl apply -f examples/run/resource-spec-taskrun.yaml ``` ## Example Pipelines diff --git a/examples/pipeline.yaml b/examples/pipeline.yaml index fee5c975399..93579a6c7d4 100644 --- a/examples/pipeline.yaml +++ b/examples/pipeline.yaml @@ -18,7 +18,7 @@ spec: - name: pathToDockerFile value: Dockerfile - name: pathToContext - value: /workspace/examples/microservices/leeroy-web + value: /workspace/workspace/examples/microservices/leeroy-web resources: inputs: - name: workspace @@ -33,7 +33,7 @@ spec: - name: pathToDockerFile value: Dockerfile - name: pathToContext - value: /workspace/examples/microservices/leeroy-app + value: /workspace/workspace/examples/microservices/leeroy-app resources: inputs: - name: workspace @@ -54,7 +54,7 @@ spec: - build-skaffold-app params: - name: path - value: /workspace/examples/microservices/leeroy-app/kubernetes/deployment.yaml + value: /workspace/workspace/examples/microservices/leeroy-app/kubernetes/deployment.yaml - name: yqArg value: "-d1" - name: yamlPathToImage @@ -72,7 +72,7 @@ spec: - build-skaffold-web params: - name: path - value: /workspace/examples/microservices/leeroy-web/kubernetes/deployment.yaml + value: /workspace/workspace/examples/microservices/leeroy-web/kubernetes/deployment.yaml - name: yqArg value: "-d1" - name: yamlPathToImage