-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Swagger UI Catalog example error #578
Fix Swagger UI Catalog example error #578
Conversation
Prior to this commit, "tektoncd" is used as catalog example in the "resouce" section of Swagger UI, which results in 404 issue when trying out the example. This commit fixes the issue by correcting "tektoncd" to "tekton"
Skipping CI for Draft Pull Request. |
/test all |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/meow
/cc @piyush-garg @PuneetPunamiya
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for the pr, the patch looks fine but I have a small concern about this because we are adding these examples in goa design to showcase user what all values can be added, but for the beginners it might be confusing as well /lgtm |
/retest |
@PuneetPunamiya I have updated the PR description and added some screenshots to show the issue better. Hope this is clearer to beginners like me 😄 |
Prior to this commit, "tektoncd" is used as a showcase example in goa-gen design. This is reflected as default example in the "resouce" section of Swagger UI, which results in 404 issue when trying out the examples with default values. This commit fixes the issue by correcting the default catalog values from "tektoncd" to "tekton"
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-check
make ui-check
See the contribution guide for more details.