Update UI dockerfile to include .npmrc file #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/M
|
/retest |
pratap0007
force-pushed
the
fix-peer-dependencies
branch
from
25b1c6d
to
2ac36bc
Compare
tekton-robot
added
size/L
|
@pratap0007 what is the reason to use node 17 instead ? |
pratap0007
force-pushed
the
fix-peer-dependencies
branch
from
2ac36bc
to
87cf02e
Compare
tekton-robot
added
size/M
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
pratap0007
changed the title
pratap0007
force-pushed
the
fix-peer-dependencies
branch
from
87cf02e
to
638b6e8
Compare
This patch incldues following changes - Adds a `.npmrc` file for npm configuration to use same npm package version as peer dependenceies package version while doing `npm install` as few npm packages peer dependecies was different from the project Signed-off-by: Shiv Verma <[email protected]>
pratap0007
force-pushed
the
fix-peer-dependencies
branch
from
638b6e8
to
e410680
Compare
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch incldues following changes
.npmrcfile for npm configuration to use same npm package versionas peer dependenceies package version while doing
npm installas few npmpackages peer dependecies was different from the project
Signed-off-by: Shiv Verma [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.