Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate the catalog refresh by job scheduling package in api #547

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Jun 22, 2022

This patch creates a cron job with help job scheduling
package(https://github.com/go-co-op/gocron) in api and does
catalog refresh on an interval and default interval is 30 minutes

Signed-off-by: Shiv Verma [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • Run UI Unit Tests, Lint Checks with make ui-check
  • Commit messages follow commit message best practices

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 22, 2022
api/.env.dev Show resolved Hide resolved
@pratap0007 pratap0007 force-pushed the add-cron branch 2 times, most recently from 1b2edf9 to bc07bb2 Compare June 23, 2022 10:32
docs/DEPLOYMENT.md Outdated Show resolved Hide resolved
@piyush-garg
Copy link
Contributor

we can remove the cron job too now which we have for catalog refresh

api/cmd/api/main.go Outdated Show resolved Hide resolved
@sm43 sm43 added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2022
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pratap0007 pratap0007 force-pushed the add-cron branch 2 times, most recently from 0ea8a5b to 8675258 Compare June 27, 2022 06:22
This patch creates a cron job with help job scheduling
package(https://github.com/go-co-op/gocron) in api and does
catalog refresh on an interval and default interval is 30 minutes

Signed-off-by: Shiv Verma <[email protected]>
@piyush-garg
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2022
@tekton-robot tekton-robot merged commit b0487de into tektoncd:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants