Adds POSTGRES_HOST as a secret for db
#543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially value for `POSRGRES_HOST` was set to `tekton-hub`, but if user wants to use his own db then he can just update the secrets of db and just use the api and ui services Hence this patch adds host as well with other fields required for connecting a database Signed-off-by: Puneet Punamiya <[email protected]>
tekton-robot
added
the
size/S
|
/lgtm Please add docs for this feature |
sm43
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially value for
POSRGRES_HOSTwas set totekton-hub,but if user wants to use his own db then he can just update
the secrets of db and just use the api and ui services
Hence this patch adds host as well with other fields required
for connecting a database
Signed-off-by: Puneet Punamiya [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.