[TEP-0110] Add an Endpoint for Fetching a Raw Tekton Resource YAML File #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XXL
|
/assign @jerop |
tekton-robot
added
the
kind/feature
austinzhao-go
force-pushed
the
main
branch
2 times, most recently
from
1f943c4
to
377e8d3
Compare
|
cc @vinamra28 |
|
/assign @vinamra28 Hi Vinamra, several points in mind.. just correct me: located the endpoint under the service
original TEP didn't mention a yaml file will be required for the return vals. use a String as return type at this moment, thinking perhaps this wouldn't work and some formatting logic I need to add right? like converting the string (or []bytes) in to a formatted yaml file |
|
/retest |
austinzhao-go
changed the title
|
/unassign |
|
cc @ywluogg |
austinzhao-go
force-pushed
the
main
branch
2 times, most recently
from
d529ac1
to
ed4cb07
Compare
vdemeester
approved these changes
Jun 23, 2022
tekton-robot
added
the
approved
vinamra28
requested changes
Jun 23, 2022
austinzhao-go
force-pushed
the
main
branch
2 times, most recently
from
ce2538c
to
e84f94b
Compare
austinzhao-go
changed the title
As for decoupling the catalog organization and tekton resource references, a new endpoint
is added to offer a resource request url only related to {catalog}, {kind}, {resourceName},
{resourceVersion} which can be directly applied with kubectl apply -f domain/v1/{catalog}/{kind}
/{name}/{version}/raw.
vinamra28
approved these changes
Jun 29, 2022
There was a problem hiding this comment.
PR looks good. Thanks @austinzhao-go 🙂
/cc @PuneetPunamiya @piyush-garg
/meow
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jerop
reviewed
Jun 29, 2022
jerop
changed the title
12 tasks
austinzhao-go
changed the title
QuanZhang-William
added a commit
to QuanZhang-William/catalog
that referenced
this pull request
Jul 15, 2022
…on Catalog Prior to this change, the installation instructions directly uses the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub by leverage the new Hub Api[tektoncd/hub#539]. This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
QuanZhang-William
added a commit
to QuanZhang-William/catalog
that referenced
this pull request
Jul 15, 2022
Prior to this change, the installation instructions directly use the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub Api: tektoncd/hub#539 This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
QuanZhang-William
added a commit
to QuanZhang-William/catalog
that referenced
this pull request
Jul 15, 2022
Prior to this change, the installation instructions directly use the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub Api: tektoncd/hub#539 This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
QuanZhang-William
added a commit
to QuanZhang-William/catalog
that referenced
this pull request
Jul 15, 2022
Prior to this change, the installation instructions directly use the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub Api: tektoncd/hub#539 This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
12 tasks
QuanZhang-William
added a commit
to QuanZhang-William/catalog
that referenced
this pull request
Jul 15, 2022
Prior to this change, the installation instructions directly use the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub Api: tektoncd/hub#539 This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
QuanZhang-William
added a commit
to QuanZhang-William/catalog
that referenced
this pull request
Aug 16, 2022
Prior to this change, the installation instructions directly use the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub Api: tektoncd/hub#539 This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
tekton-robot
pushed a commit
to tektoncd/catalog
that referenced
this pull request
Aug 16, 2022
Prior to this change, the installation instructions directly use the resource urls in the Catalog repo, which results in tight coupling between the organization and how users fetch resources (as described in TEP-0110). This commit updates the installation guide to install Tekton Catalog resources via Tekton Hub Api: tektoncd/hub#539 This change decouples the Tekton Catalog organization from resouces resolution, which enables Tekton Catalog reorganization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
/kind feature
The related TEP:
TEP-0110: Decouple Catalog Organization and Resource Reference
Add an Endpoint for Fetching a Tekton Resource YAML File as:
domain/v1/resource{catalog}/{kind}/{name}/{version}/rawThis change will support a user to directly apply the served yaml file to a cluster, like:
kubectl apply -f https://hub.tekton.dev/tekton/task/buildpacks/0.4/rawTODO
domain/v1/resource/tekton/task/git-clone/0.5/rawSubmitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-check(api-check met an existing error. the issue was raised to be tracked and fixed as [Fix] Failed API Tests
make api-check#549))make ui-checkSee the contribution guide for more details.