Allow sorting the resources by Last Updated At

[vinamra28]

Changes

Currently hub allows sorting of resources by name or rating. A user
might want to reorder the resources on the basis of their last updated
date. Adding one more parameter of LastUpdated in Dropdown of sorting.

closes #371

Signed-off-by: vinamra28 [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
• Run UI Unit Tests, Lint Checks with make ui-check
• Commit messages follow commit message best practices

See the contribution guide for more details.

[vinamra28]

/cc @pratap0007 @PuneetPunamiya

[PuneetPunamiya]

The patch overall looks good to me, just a suggestion should we change the name from LastUpdated to Recently Updated

[PuneetPunamiya]

/approve

[sm43]

/approve

[pratap0007]

if I increase screen's resolution >=150% it looks like this cc @PuneetPunamiya @piyush-garg

[piyush-garg]

if I increase screen's resolution >=150% it looks like this cc @PuneetPunamiya @piyush-garg

@vinamra28 Can you please fix this?

[PuneetPunamiya]

if I increase screen's resolution >=150% it looks like this cc @PuneetPunamiya @piyush-garg

@vinamra28 Can you please fix this?

Currently if we increase the screen resolution today as well, it will looks as the above screenshot,
Hence I think we can think we can address this in a different patch but I think we should change
the text from Last Updated -> Recently Updated if that makes sense ?

[piyush-garg]

if I increase screen's resolution >=150% it looks like this cc @PuneetPunamiya @piyush-garg

@vinamra28 Can you please fix this?

Currently if we increase the screen resolution today as well, it will looks as the above screenshot, Hence I think we can think we can address this in a different patch but I think we should change the text from Last Updated -> Recently Updated if that makes sense ?

@vinamra28 Can you please change it to Recently Updated?

[vinamra28]

@PuneetPunamiya @piyush-garg @pratap0007 updated the PR. PTAL

[pratap0007]

PR looks good to me thanks for updating it , regarding css style of sortBy one way we can improve a bit if RecentlyUpdated is selected increase the width size of Sort component -> (https://github.com/tektoncd/hub/blob/main/ui/src/components/LeftPane/index.tsx#L14 -><GridItem span={resources.sortBy == SortByFields.RecentlyUpdated ? 11 : 8}>

[pratap0007]

/retest

[pratap0007]

Thanks for updating it and looks good to me cc @piyush-garg @PuneetPunamiya

[PuneetPunamiya]

/approve
/meow

[tekton-robot]

@PuneetPunamiya:

In response to this:

/approve
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya, sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [PuneetPunamiya,sm43]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[piyush-garg]

/lgtm