Store the cloned catalog in persistent storage #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
do-not-merge/work-in-progress
tekton-robot
added
the
size/M
Since we will now be reading the catalog manifests from the cloned catalog directly instead of relying on git providers, we need to keep that catalog in persistent storage so that even if the pod is deleted, data isn't deleted. This patch Adds a PVC which will be used to store the cloned catalog after a catalog refresh is done. Also updating the deployment manifest to mount that pvc in `/tmp` directly where we are actually cloning the catalogs. Signed-off-by: vinamra28 <[email protected]>
Signed-off-by: vinamra28 <[email protected]>
vinamra28
force-pushed
the
modify-deploy-configs-docs
branch
from
e18c584
to
f62824b
Compare
tekton-robot
removed
the
do-not-merge/work-in-progress
|
/lgtm |
vdemeester
approved these changes
Feb 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Since we will now be reading the catalog manifests from the cloned
catalog directly instead of relying on git providers, we need to keep
that catalog in persistent storage so that even if the pod is deleted,
data isn't deleted. This patch Adds a PVC which will be used to store
the cloned catalog after a catalog refresh is done. Also updating the
deployment manifest to mount that pvc in
/tmpdirectly where we areactually cloning the catalogs.
Signed-off-by: vinamra28 [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.