Handles user data username case formatting #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/S
- While running the api, config.yaml has some entries of username
with some scopes added, which are stored in db, so there can be a
scenario where user's username case is different than what it is
actually on the Git application. This might loss the user's existing
data i.e. the rating of resources which user has already given
because it would create a new entry if username won't be found.
- Hence this patch checks for the case of username while inserting
the user data when user authenticates to Hub.
Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya
force-pushed
the
minor-api-fix
branch
from
7f56a4a
to
ad86189
Compare
tekton-robot
added
size/XS
|
/lgtm |
sm43
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running the api, config.yaml has some entries of username
with some scopes added, which are stored in db, so there can be a
scenario where user's username case is different than what it is
actually on the Git application. This might loss the user's existing
data i.e. the rating of resources which user has already given
because it would create a new entry if username won't be found.
Hence this patch checks for the case of username while inserting
the user data when user authenticates to Hub.
Signed-off-by: Puneet Punamiya [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.