Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow installing Hub tasks on development version of Pipelines #333

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Allow installing Hub tasks on development version of Pipelines #333

merged 1 commit into from
Nov 10, 2021

Conversation

lbernick
Copy link
Member

@lbernick lbernick commented Nov 5, 2021

Changes

The Pipelines version is pulled from the labels of the Tekton Pipelines controller, which is "devel" for the development version.
Error example: tkn hub install task golang-build returns "Error: Task golang-build(0.2) requires Tekton Pipelines min version v0.12.1 but found devel".
This change should allow pipelines developers to install Hub tasks on their installation of pipelines.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run API Unit Tests, Lint Checks, API Design, Golden Files with make api-check
  • [ X ] Run UI Unit Tests, Lint Checks with make ui-check
  • [ X ] Commit messages follow commit message best practices

See the contribution guide for more details.

@lbernick
Allow installing Hub tasks on development version of Pipelines
fd5c239 
The Pipelines version is pulled from the labels of the Tekton Pipelines controller, which is "devel" for the development version. 
Error example: `tkn hub install task golang-build` returns "Error: Task golang-build(0.2) requires Tekton Pipelines min version v0.12.1 but found devel".
This change should allow pipelines developers to install Hub tasks on their installation of pipelines.
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2021
@lbernick
Copy link
Member Author

lbernick commented Nov 5, 2021

/test pull-tekton-hub-unit-tests

@vinamra28
Copy link
Member

/retest

vinamra28
vinamra28 reviewed Nov 8, 2021
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2021
@sm43
Copy link
Member

sm43 commented Nov 8, 2021

would it be nice if we print a warning ? 🤔
because in case of devel the task may or may not be compatible?

@lbernick
Copy link
Member Author

lbernick commented Nov 8, 2021

Happy to add a warning if desired, although I think devel users expect occasional compatibility issues (?)
Could you help me figure out why the tests are failing here? It looks like the tests are not able to connect to postgres, but I'm not sure how to fix.

@sm43
Copy link
Member

sm43 commented Nov 10, 2021

/test pull-tekton-hub-unit-tests

@sm43
Copy link
Member

sm43 commented Nov 10, 2021

Happy to add a warning if desired, although I think devel users expect occasional compatibility issues (?)

yeah I agree ! lets move ahead without warning,

Could you help me figure out why the tests are failing here? It looks like the tests are not able to connect to postgres, but I'm not sure how to fix.

it seems to be an network issue. was failing to download postgres.

Thanks for the PR :)
/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sm43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2021
@tekton-robot tekton-robot merged commit dfee37e into tektoncd:main Nov 10, 2021
@vinamra28 vinamra28 mentioned this pull request Nov 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinamra28 vinamra28 vinamra28 left review comments

@sm43 sm43 Awaiting requested review from sm43

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lbernick @vinamra28 @sm43 @tekton-robot