Migrate User API's to auth server #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/XXL
PuneetPunamiya
force-pushed
the
migrate-user-to-auth-server
branch
from
9024c7e
to
ef0ae21
Compare
pratap0007
reviewed
Sep 30, 2021
api/pkg/oauth/auth/service/auth.go
Outdated
| Where("code = ?", code) | ||
|
|
||
| err := q.First(&User).Error | ||
| if err != nil { |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| if err:=r.db.Model(&model.User{}).Where("code = ?", code).First(&User).Error; err != nil { |
|
@PuneetPunamiya In case of expired refresh token |
PuneetPunamiya
force-pushed
the
migrate-user-to-auth-server
branch
2 times, most recently
from
4959d36
to
665608d
Compare
pratap0007
reviewed
Oct 14, 2021
| return nil, err | ||
| } | ||
|
|
||
| if user.RefreshTokenChecksum != createChecksum(token) { |
There was a problem hiding this comment.
token contains Header along with token value and needs to split the token value
There was a problem hiding this comment.
You mean Bearer + token ??
tekton-robot
added
the
needs-rebase
pratap0007
reviewed
Nov 10, 2021
| } | ||
|
|
||
| // Get the user Info | ||
| func (s *UserService) Info(res http.ResponseWriter, req *http.Request) { |
There was a problem hiding this comment.
should we validate the access token here ?
There was a problem hiding this comment.
Since we are using a middleware it verifies and validates the access token whenever a request is made to the endpoint
PuneetPunamiya
force-pushed
the
migrate-user-to-auth-server
branch
from
665608d
to
d7827d8
Compare
tekton-robot
added
needs-rebase
PuneetPunamiya
force-pushed
the
migrate-user-to-auth-server
branch
from
d7827d8
to
15202e6
Compare
tekton-robot
removed
the
needs-rebase
sm43
reviewed
Nov 22, 2021
api/pkg/user/base.go
Outdated
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package base |
sm43
reviewed
Nov 22, 2021
PuneetPunamiya
force-pushed
the
migrate-user-to-auth-server
branch
from
15202e6
to
02f86b6
Compare
sm43
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
- This patch removes the user design from Hub Api
server and the corresponding service logic for
user endpoints
Signed-off-by: Puneet Punamiya <[email protected]>
Signed-off-by: Puneet Punamiya <[email protected]>
This patch
- Adds `/user/info` api which returns user related
information in new auth server
- Adds a middleware which implements the authorization
logic for services
- Adds test for `/user/info` api in auth server
Signed-off-by: Puneet Punamiya <[email protected]>
This patch
- Adds `/user/refresh/accesstoken` api to get new refresh access
token for the user
- Adds test for `/user/refresh/accesstoken` api in auth server
Signed-off-by: Puneet Punamiya <[email protected]>
This patch
- Adds `/user/refresh/refreshtoken` api to get new refresh
token for the user
- Adds test for `/user/refresh/refreshtoken` api in auth server
Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya
force-pushed
the
migrate-user-to-auth-server
branch
from
02f86b6
to
31edc86
Compare
|
/test pull-tekton-hub-integration-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes user design from Hub Api Server
server and the corresponding service logic for
user endpoints
Adds implementation and test for user info in auth server
Adds
/user/infoapi which returns user relatedinformation in new auth server
Adds a middleware which implements the authorization
logic for services
Adds test for
/user/infoapi in auth serverAdds implementation for User Refresh Access Token in auth server
Adds
/user/refresh/accesstokenapi to get new refresh accesstoken for the user
Adds test for
/user/refresh/accesstokenapi in auth serverAdds implementation for New Refresh Token for User in auth server
Adds
/user/refresh/refreshtokenapi to get new refreshtoken for the user
Adds test for
/user/refresh/refreshtokenapi in auth serverSigned-off-by: Puneet Punamiya [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make api-checkmake ui-checkSee the contribution guide for more details.