Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Updates Catalog store #221

Merged
merged 1 commit into from
Apr 26, 2021
Merged

UI: Updates Catalog store #221

merged 1 commit into from
Apr 26, 2021

Conversation

pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Mar 23, 2021 •
edited
Loading

Previously we were fetching catalogs details from resources
in this patch we are fetching it from /v1/catalogs api

Signed-off-by: Shiv Verma [email protected]

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 23, 2021
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 24, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 1, 2021
@pratap0007
Copy link
Contributor Author

/retest

4 similar comments
@pratap0007
Copy link
Contributor Author

/retest

@pratap0007
Copy link
Contributor Author

/retest

@pratap0007
Copy link
Contributor Author

/retest

@pratap0007
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2021
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 12, 2021
@pratap0007
Copy link
Contributor Author

/retest

1 similar comment
@pratap0007
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 12, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2021
vinamra28
vinamra28 reviewed Apr 20, 2021
View reviewed changes
ui/src/store/resource.ts Outdated Show resolved Hide resolved
ui/src/store/catalog.ts Outdated Show resolved Hide resolved
PuneetPunamiya
PuneetPunamiya reviewed Apr 21, 2021
View reviewed changes
Copy link
Member

@PuneetPunamiya PuneetPunamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the minor changes else pr looks fine to me

PuneetPunamiya
PuneetPunamiya reviewed Apr 22, 2021
View reviewed changes
ui/public/config.js Outdated
@@ -1,4 +1,5 @@
window.config = {
API_URL: 'https://api.hub.tekton.dev',
GH_CLIENT_ID: ''
GH_CLIENT_ID: '',
API_VERSION: ''
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please update the config map and deployment manifest as well ??

PuneetPunamiya
PuneetPunamiya reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@PuneetPunamiya PuneetPunamiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we'll also have to update the start.sh file by adding API_VERSION there

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2021
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 22, 2021
@pratap0007
Updates catalog store
2bb8151 
Previously we were fetching catalogs details from resources
now we are fetching it from `/catalogs` api

Signed-off-by: Shiv Verma <[email protected]>
vinamra28
vinamra28 reviewed Apr 22, 2021
View reviewed changes
Copy link
Member

@vinamra28 vinamra28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2021
PuneetPunamiya
PuneetPunamiya reviewed Apr 23, 2021
View reviewed changes
ui/public/config.js
@@ -1,4 +1,5 @@
window.config = {
API_URL: 'https://api.hub.tekton.dev',
GH_CLIENT_ID: ''
GH_CLIENT_ID: '',
API_VERSION: 'v1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we shouldn't add this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add this to keep v1 as default ,I guess otherwise catalog wouldn't able to access

@PuneetPunamiya
Copy link
Member

Thanks 🤙
/approve
/meow
/woof

@tekton-robot
Copy link

@PuneetPunamiya: dog image

In response to this:

Thanks 🤙
/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

Thanks 🤙
/approve
/meow
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@tekton-robot tekton-robot merged commit 74739cc into tektoncd:main Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@vinamra28 vinamra28 vinamra28 left review comments

@sm43 sm43 Awaiting requested review from sm43

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @PuneetPunamiya @tekton-robot @vinamra28