UI: Adds selected filters in the url as a query parameter #214
Conversation
tekton-robot
added
the
size/L
tekton-robot
added
the
needs-rebase
tekton-robot
removed
the
needs-rebase
| resources.setURLParams(window.location.search); | ||
| } | ||
|
|
||
| return <> </>; |
There was a problem hiding this comment.
What does this return ???
There was a problem hiding this comment.
this is a React component so we need return
tekton-robot
added
the
needs-rebase
|
@pratap0007 Could you please rebase this once |
tekton-robot
removed
the
needs-rebase
ui/src/utils/updateUrl.ts
Outdated
| //To delete query params if search is empty | ||
| if (!search && searchParams.has(Params.Query)) searchParams.delete(Params.Query); | ||
|
|
||
| //Sets query params |
There was a problem hiding this comment.
| //Sets query params | |
| // Sets query params |
There was a problem hiding this comment.
@pratap0007 can you please add spaces in other comments as well?
ui/src/store/category.ts
Outdated
| @@ -45,6 +45,12 @@ export const CategoryStore = types | |||
| return Array.from(self.items.values()); | |||
| }, | |||
|
|
|||
| get selected() { | |||
There was a problem hiding this comment.
In order to keep consistency could you please change it to selectedByName
This patch updates url based on the selected filters, search query and sort by Signed-off-by: Shiv Verma <[email protected]>
|
/retest |
|
/lgtm |
|
/lgtm |
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: PuneetPunamiya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This patch updates url based on the selected filters,
search query and sort by
Signed-off-by: Shiv Verma [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.