Adds manifests and Env vars as application config #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
vinamra28
reviewed
Dec 23, 2020
vinamra28
reviewed
Dec 23, 2020
PuneetPunamiya
force-pushed
the
deployment
branch
from
aef7629
to
bd41077
Compare
vinamra28
reviewed
Dec 24, 2020
vinamra28
reviewed
Dec 24, 2020
PuneetPunamiya
force-pushed
the
deployment
branch
3 times, most recently
from
8b5d8f6
to
f1ec180
Compare
vinamra28
reviewed
Dec 24, 2020
ui/config/13-ingress.yaml
Outdated
Comment on lines
1
to
3
| apiVersion: extensions/v1beta1 | ||
| kind: Ingress | ||
| metadata: |
There was a problem hiding this comment.
Can we move this to post-deploy dir since doing a kubectl apply to the config dir would apply this as well?
Signed-off-by: Puneet Punamiya <[email protected]>
Signed-off-by: Puneet Punamiya <[email protected]>
- This adds the steps to run and test Hub UI on a local machine
or on a cluster
Signed-off-by: Puneet Punamiya <[email protected]>
PuneetPunamiya
force-pushed
the
deployment
branch
from
f1ec180
to
8d5e8ef
Compare
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pratap0007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.