Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds few UI modification #154

Merged
merged 1 commit into from
Dec 24, 2020
Merged

Adds few UI modification #154

merged 1 commit into from
Dec 24, 2020

Conversation

pratap0007
Copy link
Contributor

This patch adds:

  • Adds Tooltip to resource catalog and kind icon on resource card
  • Adds Tooltip to average rating on resource details page
  • Reduce space between rating and rating icon on resource details page
  • Replace CRA icon(browser icon) with Tekton logo
  • Moves alert a little bit down
  • Modifies resource description page width

Signed-off-by: Shiv Verma [email protected]

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

@tekton-robot tekton-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 23, 2020
vinamra28
vinamra28 reviewed Dec 24, 2020
View reviewed changes
ui/public/config.js Outdated Show resolved Hide resolved
@PuneetPunamiya
Copy link
Member

@pratap0007 Can we please add a tooltip on details page as well

@pratap0007
Adds few UI modification
721b6dd 
This patch adds:
- Adds Tooltip to resource catalog and kind icon on resource card
- Adds Tooltip to average rating on resource details page
- Reduce space between rating and rating icon on resource details page
- Replace CRA icon(browser icon) with Tekton logo
- Moves alert a little bit down
- Modifies resource description page width

Signed-off-by: Shiv Verma <[email protected]>
@PuneetPunamiya
Copy link
Member

@pratap0007 Thank you for the patch, the pr looks fine to me 🤙
/lgtm
/meow

@tekton-robot
Copy link

@PuneetPunamiya: cat image

In response to this:

@pratap0007 Thank you for the patch, the pr looks fine to me 🤙
/lgtm
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 24, 2020
@vinamra28
Copy link
Member

/lgtm

@PuneetPunamiya
Copy link
Member

/approve

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PuneetPunamiya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 24, 2020
@tekton-robot tekton-robot merged commit 5c4c8b8 into tektoncd:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PuneetPunamiya PuneetPunamiya PuneetPunamiya left review comments

@vinamra28 vinamra28 vinamra28 left review comments

@sthaha sthaha Awaiting requested review from sthaha

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vinamra28 vinamra28

@PuneetPunamiya PuneetPunamiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pratap0007 @PuneetPunamiya @tekton-robot @vinamra28