-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add theming support #1713
Comments
The Carbon Design System which provides the base components used by the Dashboard does not currently have full theme support, not all components are fully using the Carbon colour tokens and there are issues around dynamically switching themes. The theme is built into the component styles and not easily separated. We're using Gray 10 with a Gray 90 side nav (one of the components that doesn't currently have proper support for themeing). There's some work in progress / planned by the Carbon developers to include improved theme support for the next major release, Carbon 11. There's some experimental support today for CSS custom properties but I'm not sure if that's stable enough for production use yet. |
One of the Carbon issues tracking related changes: |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
/remove-lifecycle stale Theming is still important |
#2016 introduces the foundational work required to support theming (CSS custom properties), and includes some previews of how things could look based on our current design token use. More work required to complete this but it should be a lot simpler for someone to pick up once that PR is merged. |
Dark mode is available as an experimental feature since v0.17.0 or nightly builds since 2021/05/05: #2018 It can be enabled by setting a flag in the browser's localStorage: Refresh the page to see the selected theme take effect. Remaining work:
Some examples of areas to improve in dark mode:
The above should also be checked on the default light theme of course. We also need to decide:
|
Theme settings added in #2146 |
This issue tracks the addition of theming support to the Tekton Dashboard.
Right now, the Tekton Dashboard uses a somewhat dark theme, it would be nice to be able to switch between light and dark themes.
Ideally, the theme chosen by the user should be recorded so that the Dashboard always show the same theme when started.
There was no previous work around this feature but i'm sure @AlanGreene will have some helpful ideas.
The text was updated successfully, but these errors were encountered: