Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot type in the all namespace box on the left #1133

Closed
CarolynMabbott opened this issue Mar 11, 2020 · 9 comments
Closed

Cannot type in the all namespace box on the left #1133

CarolynMabbott opened this issue Mar 11, 2020 · 9 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@CarolynMabbott
Copy link
Member

Expected behavior

I can type in the All namespace box on the left to find a namespace

Actual behavior

I cant type in it

Steps to reproduce the problem

  1. Select All Namespaces box
  2. Try and type in it

Environment

  • Kubernetes Platform:
  • Tekton Pipelines version:
  • Tekton Triggers version:
  • Tekton Dashboard version:

master

Additional Info

@AlanGreene
Copy link
Member

AlanGreene commented Mar 11, 2020

I don't think this ever worked, there's code in SideNav that forces the value to 'All Namespaces' if there's no item selected.

const namespace = event.selectedItem

@AlanGreene AlanGreene changed the title can no longer type in the all namespace box on the left Cannot type in the all namespace box on the left Mar 11, 2020
@a-roberts a-roberts added the kind/bug Categorizes issue or PR as related to a bug. label Mar 11, 2020
@CarolynMabbott
Copy link
Member Author

You used to be able to type in the namespace box in the SidaNav to find a namespace

@AlanGreene
Copy link
Member

/assign

@AlanGreene
Copy link
Member

AlanGreene commented Mar 13, 2020

Regression in Carbon 10.10, issue opened: carbon-design-system/carbon#5623

@AlanGreene
Copy link
Member

AlanGreene commented Apr 2, 2020

Fix delivered to Carbon, waiting for confirmation of which release it will be included in. Hoping for 10.11.0 which is due April 7th 🤞

@AlanGreene
Copy link
Member

Confirmed this is fixed in carbon-components-react 7.11.0 (carbon-components 10.11.0) which was just released.

I'll hold off on updating until after the dashboard 0.6.1 release so we have more time to test for any other potential regressions or changes.

@AlanGreene
Copy link
Member

Carbon rolled back the release after reports of issues from multiple users... hopefully won't be too long before they fix those issues and release it again. I'll keep an eye on their release announcements and internal Slack channels so we're prepared to test it out when it lands.

@AlanGreene
Copy link
Member

Still waiting for carbon-components 10.11.0 and carbon-components-react 7.11.0 to be re-released...

@AlanGreene
Copy link
Member

[email protected] and [email protected] published

Some breaking changes compared to our current 10.10.1/7.10.1 that we'll need to account for when updating, also potentially some style / behaviour changes that we may want to review (e.g. DataTableSkeleton style changed, possibly some change in behaviour with DataTable overflow menus).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

3 participants