From aec8cb064d8f5cd72d7230cd7b173f23162e0348 Mon Sep 17 00:00:00 2001 From: Andrew Bayer Date: Tue, 14 Dec 2021 12:38:13 -0500 Subject: [PATCH] TEP-0046: Mark as implemented https://github.com/tektoncd/pipeline/pull/3843 was merged back in June. Signed-off-by: Andrew Bayer --- teps/0046-finallytask-execution-post-timeout.md | 11 ++++++++--- teps/README.md | 2 +- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/teps/0046-finallytask-execution-post-timeout.md b/teps/0046-finallytask-execution-post-timeout.md index e773b68b1..20146806f 100644 --- a/teps/0046-finallytask-execution-post-timeout.md +++ b/teps/0046-finallytask-execution-post-timeout.md @@ -1,8 +1,8 @@ --- -status: implementable +status: implemented title: Finally tasks execution post pipelinerun timeout creation-date: '2021-01-26' -last-updated: '2021-04-14' +last-updated: '2021-12-14' authors: - '@souleb' --- @@ -24,6 +24,7 @@ authors: - [Finally block level timeout flag](#finally-block-level-timeout-flag) - [Pipelinerun timeout is inclusive of the finally tasks timeout](#pipelinerun-timeout-is-inclusive-of-the-finally-tasks-timeout) - [Finally Timeout flag at Pipelinerun Spec](#finally-timeout-flag-at-pipelinerun-spec) +- [References](#references) ## Summary @@ -308,4 +309,8 @@ This solution was deemed confusing. The user could expect the `timeout` to be fo ### Finally Timeout flag at Pipelinerun Spec -We could add a new flag at the pipelineRun level `finallyTimeout` similar to the timeout flag. If specified, pipelineRun timeout (default is one hour) applies to dag tasks only. The dag tasks will stop executing once it meets the pipelineRun timeout. The finally tasks starts executing at this point and will be executed until meets the timeout specified in finallyTimeout. \ No newline at end of file +We could add a new flag at the pipelineRun level `finallyTimeout` similar to the timeout flag. If specified, pipelineRun timeout (default is one hour) applies to dag tasks only. The dag tasks will stop executing once it meets the pipelineRun timeout. The finally tasks starts executing at this point and will be executed until meets the timeout specified in finallyTimeout. + +## References + +* [tektoncd/pipeline PR #3843 - Add a Timeouts optional field to pipelinerun](https://github.com/tektoncd/pipeline/pull/3843) diff --git a/teps/README.md b/teps/README.md index 3aa646127..cd654870a 100644 --- a/teps/README.md +++ b/teps/README.md @@ -198,7 +198,7 @@ This is the complete list of Tekton teps: |[TEP-0042](0042-taskrun-breakpoint-on-failure.md) | taskrun-breakpoint-on-failure | implemented | 2021-12-10 | |[TEP-0044](0044-decouple-task-composition-from-scheduling.md) | Decouple Task Composition from Scheduling | proposed | 2021-12-07 | |[TEP-0045](0045-whenexpressions-in-finally-tasks.md) | WhenExpressions in Finally Tasks | implemented | 2021-06-03 | -|[TEP-0046](0046-finallytask-execution-post-timeout.md) | Finally tasks execution post pipelinerun timeout | implementable | 2021-04-14 | +|[TEP-0046](0046-finallytask-execution-post-timeout.md) | Finally tasks execution post pipelinerun timeout | implemented | 2021-12-14 | |[TEP-0047](0047-pipeline-task-display-name.md) | Pipeline Task Display Name | proposed | 2021-02-10 | |[TEP-0048](0048-task-results-without-results.md) | Task Results without Results | proposed | 2021-06-11 | |[TEP-0049](0049-aggregate-status-of-dag-tasks.md) | Aggregate Status of DAG Tasks | implemented | 2021-06-03 |