Change way of question for "insecure" parameter #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cluster pipielineresource creation uses a parameter insecure for which the question asked is "Enter a value for insecure param" and user needed to type true or false now question is changed to "Is your cluster secure?" and user can choose between yes or no from the options provided on console which is internally mapped to true/false Signed-off-by: Pradeep Kumar <[email protected]>
tekton-robot
added
the
size/M
pradeepitm12
changed the title
piyush-garg
approved these changes
Oct 17, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: piyush-garg, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cluster pipielineresource creation uses a parameter insecure
for which the question asked is "Enter a value for insecure param"
and user needed to type true or false
now question is changed to "Is your cluster secure?" and user can
choose between yes or no from the options provided on console
which is internally mapped to true/false
Signed-off-by: Pradeep Kumar [email protected]
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make docsandmake manif needed.make checkSee the contribution guide
for more details.
Release Notes