Fixes 0.6.0 version compatibility issues #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
approved
|
The following is the coverage report on pkg/.
|
hrishin
changed the title
|
The following is the coverage report on pkg/.
|
|
/hold |
tekton-robot
added
the
do-not-merge/hold
|
/hold cancel |
tekton-robot
removed
the
do-not-merge/hold
vdemeester
approved these changes
Aug 21, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hrishin, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The perline version 0.6.0 has introduced following changes - Pipeline/PipelineParam was the string value, now it has changed to ArrayOrString - SeedTestData method were accpeting two params, now it has introduced `context` as 3rd param which essentially broke the compatbility with execsting pipeline API's This patch fixes, - Pipeline/PipelineRun params now refers to type of ArrayOrString - SeedTestData() utility fixes the context param issue, by extracting the function call at one place. So in future if API changes, hopefully need to fix at one place Fixes tektoncd#220
hrishin
force-pushed
the
0.6-version-fix
branch
from
12e3678
to
cca0058
Compare
|
/lgtm |
hrishin
force-pushed
the
0.6-version-fix
branch
from
cca0058
to
7e0a500
Compare
|
/lgtm |
hrishin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The pipeline version 0.6.0 has introduced following changes
changed to ArrayOrString
SeedTestDatamethod were accepting two params, now it hasintroduced
contextas 3rd paramwhich essentially broke the compatibility with existing pipeline
API's
This patch fixes,
the function call at one place. So in future if API changes, hopefully
need to fix at one place
Fixes #220
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.
Release Notes