Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Deprecate trigger Alias for Pipeline Start and Task Start #531

Closed
danielhelfand opened this issue Dec 18, 2019 · 2 comments · Fixed by #755
Closed

Proposal: Deprecate trigger Alias for Pipeline Start and Task Start #531

danielhelfand opened this issue Dec 18, 2019 · 2 comments · Fixed by #755
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature
Milestone
0.8.0 🐯

Comments

@danielhelfand
Copy link
Member

We currently support the alias trigger for tkn pipeline start and tkn task start. I think it's not used very often, and it may become confusing as the CLI starts to add in features around the triggers project.

I think a simple process would be to make an announcement as part of our next release that trigger will be deprecated and then we officially remove it in v0.8.0. If we would like to go further and include some kind of message in the CLI, we could work on that for v0.7.0.

Version and Operating System

tkn Version: master branch

Operating System: N/A
@danielhelfand
Copy link
Member Author

/kind feature
/kind question

@tekton-robot tekton-robot added kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature labels Dec 18, 2019
@chmouel
Copy link
Member

chmouel commented Dec 18, 2019

make sense +1 from me!

@danielhelfand danielhelfand added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Dec 27, 2019
@danielhelfand danielhelfand added this to the 0.8.0 🐯 milestone Feb 4, 2020
@vdemeester vdemeester mentioned this issue Feb 27, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. kind/question Issues or PRs that are questions around the project or a particular feature
Projects
None yet
Milestone
0.8.0 🐯
Development

Successfully merging a pull request may close this issue.

Remove trigger alias for start subcommands 🚉 vdemeester/tektoncd-cli
3 participants
@chmouel @danielhelfand @tekton-robot