Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"rerun" of pipelineRun in OpenShift, doesn't clear annotations #1004

Open
mtcolman opened this issue Dec 1, 2023 · 3 comments
Open

"rerun" of pipelineRun in OpenShift, doesn't clear annotations #1004

mtcolman opened this issue Dec 1, 2023 · 3 comments

Comments

@mtcolman
Copy link
Contributor

mtcolman commented Dec 1, 2023

Hi, I'm still doing some further testing, with which I'll update this ticket, but wondered @lcarva if you've seen anything around the annotatations of a pipelineRun where attestation is marked as Failed - if I rerun this pipelineRun (using the "rerun" button in OpenShift), then before the pipelineRun has completed, I can see the annotation chains.tekton.dev/signed: false is not cleared and attestation is not uploaded to repo.

I think I have all secrets etc in the right place.

Thanks in advance.

@lcarva
Copy link
Contributor

lcarva commented Dec 1, 2023

This is probably not something that should be handled at the Chains level.

See tektoncd/pipeline#6127.

@mtcolman
Copy link
Contributor Author

mtcolman commented Dec 1, 2023

OK, thanks. Do you think it's something maybe the documentation needs to call out? e.g., rerun of pipelineRun that has been marked with these annotations will not work correctly/give ambiguous results? Or is this something that is known, but I've missed?

@lcarva
Copy link
Contributor

lcarva commented Dec 1, 2023

+1 to adding something to the docs!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants