lib: rpmsg: replace strncpy with internal strlcpy

The strncpy function does not ensure that the destination string is
null-terminated. To address this issue, replace strncpy with the
internal strlcpy function, which guarantees null-termination of the
destination string.

Note: (void)strlcpy(...) indicates that the return value is intentionally
ignored.

Signed-off-by: Arnaud Pouliquen <[email protected]>
(cherry picked from commit e83acc98ad18f27bd1c12de808aaed84a0091791)

Upstream PR: OpenAMP/open-amp#620

Signed-off-by: Tomi Fontanilles <[email protected]>
Signed-off-by: Torsten Rasmussen <[email protected]>

open-amp/lib/rpmsg/rpmsg.c

@@ -7,6 +7,7 @@
  * SPDX-License-Identifier: BSD-3-Clause
  */
 
+#include <internal/string.h>
 #include <openamp/rpmsg.h>
 #include <metal/alloc.h>
 
@@ -141,7 +142,7 @@ int rpmsg_send_ns_message(struct rpmsg_endpoint *ept, unsigned long flags)
 
 	ns_msg.flags = flags;
 	ns_msg.addr = ept->addr;
-	strncpy(ns_msg.name, ept->name, sizeof(ns_msg.name));
+	(void)strlcpy(ns_msg.name, ept->name, sizeof(ns_msg.name));
 	ret = rpmsg_send_offchannel_raw(ept, ept->addr,
 					RPMSG_NS_EPT_ADDR,
 					&ns_msg, sizeof(ns_msg), true);
@@ -305,7 +306,7 @@ void rpmsg_register_endpoint(struct rpmsg_device *rdev,
 			     rpmsg_ept_cb cb,
 			     rpmsg_ns_unbind_cb ns_unbind_cb, void *priv)
 {
-	strncpy(ept->name, name ? name : "", sizeof(ept->name));
+	(void)strlcpy(ept->name, name ? name : "", sizeof(ept->name));
 	ept->refcnt = 1;
 	ept->addr = src;
 	ept->dest_addr = dest;