Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement two unpacker apis on the structs. One read only and one with a packer state. #5

Open
ChillerDragon opened this issue Jun 25, 2024 · 2 comments
Open

Implement two unpacker apis on the structs. One read only and one with a packer state. #5

ChillerDragon opened this issue Jun 25, 2024 · 2 comments

Comments

@ChillerDragon
Copy link
Member

It would be nice to have two unpack methods for all structs

  • Unpack(u *packer.Unpacker)
  • UnpackTodoFindAGoodName(data []byte)
@jxsl13
Copy link
Contributor

jxsl13 commented Jun 25, 2024

https://pkg.go.dev/encoding#BinaryUnmarshaler

@jxsl13
Copy link
Contributor

jxsl13 commented Jun 25, 2024

The problem with these byte slices is that they are often not meant for streaming, meaning, your payload may only contain the actual object and not more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jxsl13 @ChillerDragon