Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log hash of the beakerlib library repo #2843

Merged
merged 1 commit into from
May 2, 2024
Merged

Log hash of the beakerlib library repo #2843

merged 1 commit into from
May 2, 2024

Conversation

lukaszachy
Copy link
Collaborator

Make common tmt.utils.git_hash function to have single way of getting this information

Pull Request Checklist

  • implement the feature

@lukaszachy lukaszachy added code | utils Various utility functions and classes used across the code area | libraries Issues related to beakerlib libraries support labels Apr 10, 2024
@lukaszachy lukaszachy added this to the 1.33 milestone Apr 10, 2024
happz
happz reviewed Apr 11, 2024
View reviewed changes
tmt/utils.py Outdated Show resolved Hide resolved
@lukaszachy lukaszachy requested a review from happz April 23, 2024 11:48
psss
psss approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this! Looks good, just fixed a typo with some minimal adjustments in bc5df8f.

@psss psss added the ci | full test Pull request is ready for the full test execution label Apr 30, 2024
thrix
thrix approved these changes Apr 30, 2024
View reviewed changes
Copy link
Collaborator

@thrix thrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukaszachy @psss
Log hash of the beakerlib library repo
0995849 
Make common tmt.utils.git_hash function to have single way of getting
this information
@psss psss self-assigned this May 2, 2024
@psss psss merged commit 0995849 into main May 2, 2024
20 checks passed
@psss psss deleted the log-library-hash branch May 2, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therazix therazix therazix approved these changes

@psss psss psss approved these changes

@thrix thrix thrix approved these changes

@happz happz happz approved these changes

@janhavlin janhavlin Awaiting requested review from janhavlin janhavlin is a code owner

Assignees

@psss psss

Labels
area | libraries Issues related to beakerlib libraries support ci | full test Pull request is ready for the full test execution code | utils Various utility functions and classes used across the code
Projects
None yet
Milestone
1.33
Development

Successfully merging this pull request may close these issues.
5 participants
@lukaszachy @happz @thrix @psss @therazix