-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EasyMotion doesn't work in Sublime Text 3 #26
Comments
It likely won't work in ST3 until the API gets much better documentation. One of the main APIs that EasyMotion relies on in ST2 is the ability to create and close an For some reason, this has been removed from the ST3 API, "API: begin_edit() / end_edit() are no longer accessible" from Selected Changes. If there is no substitute for this, it's likely that I won't be able to migrate the plugin to ST3. |
Removed isn't probably the right word. Will begin_end() and end_edit() are no longer directory accessible, except in some special circumstances. The only way to get a valid instance of an Edit object is to place your code in a TextCommand subclass. In general, most code can be refactored by placing the code between begin_edit() and end_edit() in a TextCommand, and then calling run_command on that TextCommand. This approach removes the issue of dangling Edit objects, and ensures the repeat command and macros work as they should. or be of any help? ST3 without EasyMotion? I wouldn't switch... |
Thanks, but I've looked at both of those. They suggest using a TextCommand as it automatically opens and closes an edit object for you. Unfortunately, I need an edit object to live beyond the life of what a TextCommand does. This type of auto open/closed edit also exists on ST2 and I attempted to implement it that way when I first made the plugin. But then I found it wouldn't work because the edit object gets closed and I can't control that. This API change makes sense for most plugins, but as far as I've seen will make EasyMotion unportable unless there's something hidden in the API...I'm hoping things get better documentation in the next few months and I'll keep monitoring to see if some new way pops up to implement things. |
I've given this a shot using just I haven't tried it in ST3, just in ST2. I'm hoping that there will be something else in the ST3 API that I can use or try once it's better documented. It could also be that ST3 handles the callbacks a little differently and is more consistent in how |
Has there been any update to this recently? |
Not from what I've seen from the API of ST3. There is a dev branch that I have where I'm trying a technique that could work on ST3 (it pops up a new buffer and fills it in with all of the content on the view screen that you were looking at for character selection, then makes the buffer go away), but it needs a lot more work before it's feature compatible with the currently released version (or really even working). I likely won't focus much on it till ST3 is actually released and the API is pretty much locked down at that point. |
But what if the API is locked down to a point where the current functionality of EasyMotion is no longer possible to implement? One might consider that an acceptable risk, shrug if it happens and just try to build some equivalent functionality using the ST3 API, but based on the descriptions here, the current ST2 implementation seems nicer than the proposed (and incomplete) ST3 implementation. If there is a need for advocacy for the necessary APIs to be included in ST3, just point me to the relevant tickets or communication channels and I'll try to contribute my two cents there, and I suggest others do the same. |
I'm not currently using ST3 and likely won't till it's final and there is some compelling reason to upgrade (haven't seen one yet to use the beta over ST2). The API that's available for ST3 now is very limiting. I've got a couple of ideas on how it could be implemented, but the experience would not be as good as the ST2 experience and would take a lot of additional work (it likely would involve popping up a new tab that's a copy of the existing window and then closing that when the user makes the selection). The vast majority of people who use sublime are still on ST2, so switching the plugin over to using that style with the degraded experience while the ST2 stuff still works doesn't make sense to me (there's no way that I know of to say that changes are only to be for ST3 but not installed on ST2 without making a brand new plugin). When ST3 is released and most people have converted over, I'll look at upgrading the plugin, but there isn't much incentive for me to do it till then. |
I made this to make handling edit groups easier in ST3: http://www.sublimetext.com/forum/viewtopic.php?f=6&t=12551 |
Thanks @lunixbochs that looks interesting. I'll take a closer look at it and see if I can repurpose it and make it work with EasyMotion for ST3. |
How about now that there's a public release? Many devs and plugins (like Emmet) have already made the jump. Love this plugin, can't wait to use it again. |
Really interested on the ST3 version also. Thanks for the effort. |
There is now support on the For now, you'd need to check the code out to your ST3/Packages directory and I'll update the main docs and close this issue once I get some confirmation from others that the |
I'm not using ST3 in my daily work currently, but I haven't heard of any issues with ST3 support since releasing it, so I'm guessing it's working for everyone. I'm closing this issue as fixed, if there are further issues just open another one up. |
Hi tednaleid, I just did as you said, everything is good. But when I type cmd+; in the st3, nothing happened. Maybe caused by the st3's update? |
@Hexor, before I encountered exactly the same problem like you. I solved it now. Reinstall ST3 (NOTICE! DO NOT install any other package) Then EasyMotion works! I think the packages I installed before are in conflict with EsayMotion. |
Thanks @democ, It's really works! But it takes lots of my time to reinstall every other package. Anyway, worth it. |
oh man.. really want this for st3, but the keyboard shortcut only works a few times out of a dozen tries. Reinstalling is not really an option, especially if it may break anyway... |
After issuing the |
It appears that this plugin doesn't work in Sublime Text 3. I've tried a bunch of things, but sadly my knowledge doesn't go far enough to properly fix this...
The text was updated successfully, but these errors were encountered: