Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request.pause() does no longer stop memory overflow (regression) #877

Closed
chdh opened this issue Mar 14, 2019 · 2 comments
Closed

Request.pause() does no longer stop memory overflow (regression) #877

chdh opened this issue Mar 14, 2019 · 2 comments

Comments

@chdh
Copy link
Collaborator

chdh commented Mar 14, 2019 •
edited
Loading

Up to Tedious 2.6.4 everything works fine, but starting with Tedious 2.7.0 the memory keeps getting filled with data from the SQL server even after Request.pause() has been called.

This problem has been reported by @gsamal in a comment to #518, and in tediousjs/node-mssql#832.

I have written a test program that confirms the problem: testPauseResume.zip
@chdh chdh mentioned this issue Mar 14, 2019
Merged
@arthurschreiber
Copy link
Collaborator

This was fixed via #878.

@arthurschreiber
Copy link
Collaborator

The fix for this is part of the 6.0.1 release. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arthurschreiber @chdh